Update wasmparser on the 3.0.0 update branch #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring these up-to-date with the latest.
These dependencies are far behind the latest versions so this fast-forwards them up to versions where larger changes are required. This updates them enough to perform some minor rewrites here and there but nothing major is changing.
This involved deleting quite a bit more module-linking related code in `wizer`.
…mory This commit further updates the `wasmparser` dependency across some versions with minor renamings and structuring of the API. This pulls in enough support to get the `multi_memory` test passing.
Merged
|
Also it seems prudent to further update various dependencies to their latest versions but for now I figure it's best to land the Wasmtime 3.0.0 update first and then try to go further from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to update the
jake/wasmtimebranch which updates Wasmtime to 3.0.0. I believe the main blocker on that PR was a failing multi memory test which was due to thewasmparserused bywizerbeing too old. This updateswasmparseracross the "great module linking removal" which necessitated deleting a lot more code in wizer related to module linking. To the best of my knowledge that's in line with the original intention of #65 so I'm hoping it's ok.I'll note that I applied a mostly hack-and-slash approach to deleting module-linking code. I'm not intimiately familiar with everything deleted here.