Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-53) bumped Cake to 1.0.0 #54

Merged
merged 1 commit into from
Feb 10, 2021
Merged

(GH-53) bumped Cake to 1.0.0 #54

merged 1 commit into from
Feb 10, 2021
+10 −42

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Feb 9, 2021

Description

bumped Cake.Core, Cake.Common and Cake.Testing to version 1.0.0
Had to change some of tests for that to compile again.

Related Issue

fixes #53

Motivation and Context

https://cakebuild.net/blog/2021/02/cake-v1.0.0-released

How Has This Been Tested?

Build, ran unittest and did a small manual integration test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

augustoproiete
augustoproiete approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nils-a nils-a merged commit 5729a3d into cake-contrib:develop Feb 10, 2021
@nils-a nils-a deleted the feature/GH-53 branch February 10, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

@Redth Redth Awaiting requested review from Redth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Cake.ExtendedNuGet to target Cake v1.0.0
2 participants
@nils-a @augustoproiete