Resolve: 15883 Node js upgrade #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@copelco Sorry for the big file diff! Most of these changes are either import path updates and eslint formatting. |
copelco
reviewed
Jul 15, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM node:12.16-alpine as static_files | |||
There was a problem hiding this comment.
Oh interesting, I've been using v16 locally this whole time 😮
A couple of the warnings have been lingering before this upgrade, I'll see if I can tackle that last one, the Edit: @copelco Fixed! |
copelco
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslintformatter onfrontendfilesAsyncRoute.js->FJRoute.jsto remove async component import which broke in React 18Needs QA testing, more than usual (Just in case I caused a regression)
Closes #15883