Add support for caching api/mat views. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iews to use cache mixin
Afani97
force-pushed
the
update-api-views-to-cache-responses
branch
from
a2604c2 to
7066aac
Compare
copelco
approved these changes
Feb 21, 2024
nc/views.py
Outdated
| @@ -89,6 +89,9 @@ class QueryKeyConstructor(DefaultObjectKeyConstructor): | |||
| query_cache_key_func = QueryKeyConstructor() | |||
|
|
|||
|
|
|||
| CACHE_TIMEOUT = 60 * 60 * 24 | |||
There was a problem hiding this comment.
Maybe we can settings.CACHE_COUNT_TIMEOUT here?
There was a problem hiding this comment.
Ah didn't see that, will update.
copelco
reviewed
Feb 21, 2024
nc/models.py
Outdated
| @@ -265,7 +265,7 @@ def census_profile(self): | |||
| """ # noqa | |||
|
|
|||
|
|
|||
| class StopSummary(pg.ReadOnlyMaterializedView): | |||
| class StopSummary(CachingMixin, pg.ReadOnlyMaterializedView): | |||
There was a problem hiding this comment.
I'd be okay leaving these off TBH, and just relying on the cache_page decorators. I think we should remove django-cache-machine during our next upgrade..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed:
cache_pagemethod decorator instead of drf extensionscache_responsesince it's not been maintained in a while and is crashing the backend.