Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js syntax to fix node 22 #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

js syntax to fix node 22 #261

wants to merge 1 commit into from

Conversation

tiye
Copy link
Member

@tiye tiye commented Mar 9, 2025

No description provided.

@tiye tiye requested review from a team and Copilot March 9, 2025 17:58
Copy link
Contributor

coderabbitai bot commented Mar 9, 2025

Walkthrough

The changes increment the version number to "0.9.9" across multiple files and adjust an import statement in the TypeScript module. Specifically, version values in Cargo.toml, README.md, and package.json have been updated from "0.9.8" to "0.9.9", and the JSON module import in ts-src/calcit.procs.mts now uses with instead of assert. No changes were made to the underlying logic or control flow.

Changes

File(s) Change Summary
Cargo.toml, package.json, README.md Updated version numbers from "0.9.8" to "0.9.9" in metadata and version declarations.
ts-src/calcit.procs.mts Changed JSON module import syntax from assert { type: "json" } to with { type: "json" }.

Poem

Bouncing through updates with joy so sincere,
I hopped through code and made changes clear.
Versions climb high, a leap so fine,
With a with for my import, all now align.
Here's a bunny cheer, bringing smiles near! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f686ee5 and 7096704.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • README.md (1 hunks)
  • package.json (1 hunks)
  • ts-src/calcit.procs.mts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Publish to cargo
🔇 Additional comments (4)
package.json (1)

3-3: Version update to 0.9.9 looks good.

The version increment from 0.9.8 to 0.9.9 aligns with the changes in other files.

Cargo.toml (1)

3-3: Version update to 0.9.9 looks good.

The version increment from 0.9.8 to 0.9.9 is consistent with the package.json update.

README.md (1)

103-103: Version update to 0.9.9 looks good.

The version increment in the deps.cirru section maintains consistency with other file updates.

ts-src/calcit.procs.mts (1)

1-1:

✅ Verification successful

Appropriate syntax update for Node.js 22 compatibility.

The change from assert { type: "json" } to with { type: "json" } reflects the current standard for JSON module imports in newer Node.js versions.


🌐 Web query:

Node.js 22 JSON module import assert vs with syntax

💡 Result:

In Node.js 22, importing JSON modules requires the with { type: "json" } syntax instead of the older experimental assert syntax. This change aligns with updates to the ECMAScript specification and Node.js's transition to standardized import attributes. Here's a breakdown:

Key Changes in Node.js 22

  1. with Syntax Adoption:

    • The import statement now uses with for attributes:
      import data from "./data.json" with { type: "json" };
    • Dynamic imports also follow this pattern:
      const { default: data } = await import("./data.json", { with: { type: "json" } });

    This replaces the deprecated assert keyword used in earlier versions[9][12].

  2. Deprecation of assert:

    • The assert { type: "json" } syntax, which was flagged as experimental in Node.js 18 and earlier, is no longer the recommended approach. While it might still work temporarily, it is being phased out in favor of with[1][12].
  3. Why the Change?:

    • Spec Alignment: The shift to with follows updates to the TC39 proposal for import attributes, which reframed the syntax to avoid confusion with Node.js's existing assert module[2][12].
    • Consistency: Using with ensures compatibility with browsers and other JavaScript environments adopting the same standard[6][9].

Practical Example

// Valid in Node.js 22
import config from "./app-config.json" with { type: "json" };
console.log(config.apiUrl);  // Access parsed JSON properties

// Dynamic import equivalent
const { default: config } = await import("./app-config.json", { with: { type: "json" } });

Backward Compatibility

  • Projects using assert syntax will need to update imports to avoid future breakage. Node.js 22 may still support assert behind flags (e.g., --experimental-import-assertions), but this is not recommended for production[1][12].

For long-term stability, use with for JSON imports in Node.js 22 and newer versions.

Citations:


Syntax Update Verified for Node.js 22 Compatibility

The import statement now correctly uses the with { type: "json" } syntax, which is fully aligned with Node.js 22 and the updated ECMAScript specification. No further modifications are necessary.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Node.js import syntax for JSON modules to support Node 22 and bumps the package version accordingly.

  • Update import syntax in ts-src/calcit.procs.mts
  • Increment package version in Cargo.toml and update the same in README.md

Reviewed Changes

File Description
ts-src/calcit.procs.mts Changed import syntax for package.json to support Node 22.
Cargo.toml Bumped the package version from 0.9.8 to 0.9.9.
README.md Updated the calcit version to match the version bump.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@@ -1,4 +1,4 @@
import pkg from "./package.json" assert { type: "json" };
import pkg from "./package.json" with { type: "json" };
Copy link
Preview

Copilot AI Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that the 'with' clause syntax is officially supported in Node 22, as the standard syntax has traditionally been using 'assert'.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant