-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js syntax to fix node 22 #261
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes increment the version number to "0.9.9" across multiple files and adjust an import statement in the TypeScript module. Specifically, version values in Cargo.toml, README.md, and package.json have been updated from "0.9.8" to "0.9.9", and the JSON module import in ts-src/calcit.procs.mts now uses Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the Node.js import syntax for JSON modules to support Node 22 and bumps the package version accordingly.
- Update import syntax in ts-src/calcit.procs.mts
- Increment package version in Cargo.toml and update the same in README.md
Reviewed Changes
File | Description |
---|---|
ts-src/calcit.procs.mts | Changed import syntax for package.json to support Node 22. |
Cargo.toml | Bumped the package version from 0.9.8 to 0.9.9. |
README.md | Updated the calcit version to match the version bump. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
@@ -1,4 +1,4 @@ | |||
import pkg from "./package.json" assert { type: "json" }; | |||
import pkg from "./package.json" with { type: "json" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify that the 'with' clause syntax is officially supported in Node 22, as the standard syntax has traditionally been using 'assert'.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's intentional
No description provided.