-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rerouting a booking with corrected responses #17074
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
E2E results are ready! |
4919e31
to
f0c6e94
Compare
24f52f5
to
ce6a721
Compare
packages/features/bookings/lib/handleNewBooking/createBooking.ts
Outdated
Show resolved
Hide resolved
@hariombalhara rest of the code looks fine. Just some missing translation which can be fixed later. |
Thank you @Udit-takkar !! Let's merge it then. Have pushed some of @CarinaWolli's suggestions as well. |
Icon test is consistent failure !! |
This reverts commit 6d4bbf6.
The icons snapshot needs to be updated due to new icons added. |
What does this PR do?
Fixes CAL-4498
Loom Demo - With new UI Changes
Old Loom Demo - Not updated with UI/UX changes but should work
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
See Loom
Review Ask
While reviewing please make sure to specifically review that it doesn't break any existing behaviour