Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rerouting a booking with corrected responses #17074

Merged
merged 22 commits into from
Oct 18, 2024

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Oct 12, 2024

What does this PR do?

Fixes CAL-4498

Loom Demo - With new UI Changes
Old Loom Demo - Not updated with UI/UX changes but should work

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

See Loom

Review Ask

While reviewing please make sure to specifically review that it doesn't break any existing behaviour

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 8:41pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 8:41pm

Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "POC working with no TS error". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 12, 2024
@hariombalhara hariombalhara changed the title POC working with no TS error feat: Rerouting a booking with updated responses Oct 12, 2024
@hariombalhara hariombalhara changed the title feat: Rerouting a booking with updated responses feat: Rerouting a booking with updated Routing Form responses Oct 12, 2024
@hariombalhara hariombalhara self-assigned this Oct 12, 2024
Copy link
Contributor

github-actions bot commented Oct 12, 2024

E2E results are ready!

@Udit-takkar
Copy link
Contributor

@hariombalhara rest of the code looks fine. Just some missing translation which can be fixed later.

@hariombalhara
Copy link
Member Author

Thank you @Udit-takkar !! Let's merge it then. Have pushed some of @CarinaWolli's suggestions as well.

Udit-takkar
Udit-takkar previously approved these changes Oct 18, 2024
@hariombalhara
Copy link
Member Author

Icon test is consistent failure !!

This reverts commit 6d4bbf6.
@zomars
Copy link
Member

zomars commented Oct 18, 2024

Icon test is consistent failure !!

The icons snapshot needs to be updated due to new icons added.

@zomars
Copy link
Member

zomars commented Oct 18, 2024

Posting here as well for visibility.

How to update the icons snapshot:

  1. Go to the tests results
    image
  2. Find the failing icon test
    image
  3. Scroll to bottom and download the icons-expected.png file
    image
  4. Rename it replacing the one in: playwright/icons.e2e.ts-snapshots/icons--calcom-web-linux.png
  5. Commit it and push it

@Udit-takkar Udit-takkar merged commit b8d4fcc into main Oct 18, 2024
37 checks passed
@Udit-takkar Udit-takkar deleted the reroute-with-corrected-responses branch October 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request ready-for-e2e routing-forms area: routing forms, routing, forms Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants