Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code regarding insights #19022

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 31, 2025

What does this PR do?

showRoutingFilters is never true.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:37pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 4:37pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 4:37pm

Base automatically changed from eunjae/cal-5075-check-filters-on-insightsrouting to main January 31, 2025 16:16
@eunjae-lee eunjae-lee force-pushed the chore/remove-dead-code branch from e057694 to c03649c Compare January 31, 2025 16:20
@eunjae-lee eunjae-lee marked this pull request as ready for review January 31, 2025 16:20
@graphite-app graphite-app bot requested a review from a team January 31, 2025 16:20
@dosubot dosubot bot added the insights area: insights, analytics label Jan 31, 2025
Copy link

graphite-app bot commented Jan 31, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/31/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

E2E results are ready!

@eunjae-lee eunjae-lee merged commit 7bbacca into main Jan 31, 2025
62 of 83 checks passed
@eunjae-lee eunjae-lee deleted the chore/remove-dead-code branch January 31, 2025 18:23
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only insights area: insights, analytics ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants