-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move main.py into package and add vanity CLI #57
base: master
Are you sure you want to change the base?
Move main.py into package and add vanity CLI #57
Conversation
@@ -80,4 +80,9 @@ def find_version(*file_paths): | |||
'scikit-learn==0.23.2', | |||
'tqdm==4.54.1'], | |||
extras_require=extras, | |||
entry_points={ | |||
"console_scripts": [ | |||
'omop2obo = omop2obo.main:main', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change the name of the python file from main.py
to cli.py
, change this line like:
'omop2obo = omop2obo.main:main', | |
'omop2obo = omop2obo.cli:main', |
@cthoyt - Thanks so much for doing this. I've got some big deadlines this week and will work on merging your changes this weekend. |
@callahantiff no rush! good luck |
Greetings from the future @callahantiff congrats on the 1.0 release, I just updated the code vs the main branch and this could still be merged if you want |
Thanks so much, @cthoyt!! - I am so sorry that I have not included the awesome work you did in release |
Closes #56
This PR does the following:
main.py
into the main package hierarchy. My personal preference is to name the filecli.py
, but I'll leave this as an option to you__main__.py
for usage aspython -m omop2obo
as well as docs in the top explaining what's going onHappy ontologizing!