Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat project #762

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Reformat project #762

merged 6 commits into from
Feb 7, 2025

Conversation

ChrisKujawa
Copy link
Collaborator

@ChrisKujawa ChrisKujawa commented Feb 7, 2025

To fix our houndreds of compilation warnings due to different code style.

  • Reformat code with Rider and VSCode
  • Add braces for single statements
  • introduce _ for non used returns
  • remove empty statements
  • ignore dependency issues for .net 6 support

Before:

    542 Warning(s)
    0 Error(s)

After:

    79 Warning(s)
    0 Error(s)

Apply codestyle, and reformting from Rider
 * Reformat code
 * Add braces for single statements
 * introduce _ for non used returns
 * remove empty statements
 * ignore dependency issues for .net 6 support
 * .net 6 and .net8 are out of support
 * Both were causing dotnet test to fail builds - return code 1
 * Remove SuppressWarnings as no longer need due to removal of older .net
@ChrisKujawa ChrisKujawa merged commit c246f53 into main Feb 7, 2025
5 checks passed
@ChrisKujawa ChrisKujawa deleted the ck-reformat-project branch February 7, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant