Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modeler API endpoints using wrong HTTP method(s) #269

Closed
tijmenstor opened this issue Oct 23, 2024 · 1 comment
Closed

Modeler API endpoints using wrong HTTP method(s) #269

tijmenstor opened this issue Oct 23, 2024 · 1 comment
Assignees
@jwulf

Comments

@tijmenstor
Copy link

SDK Component

Modeler

Expected Behavior

I should be able to make use of all the API endpoints using the modeler client from this package.

Current Behavior

Specifically, when I want to make use of searchFiles and updateFile, errors are being thrown. Looking at the code for searchFiles for example, it uses GET as its HTTP method. The Swagger UI however indicates that this specific endpoint makes use of POST (link).

Possible Solution

Change the functions to make use of the correct HTTP endpoints.

Steps to Reproduce

  1. Initialize a modeler client using the latest version of this package
  2. Try to make use of searchFiles to query the respective API endpoint
  3. Receive an error like The GET method cannot be used with a body

Context (Environment)

We are making use of the API endpoints in our deployment automation.
@jwulf jwulf self-assigned this Oct 23, 2024
@jwulf
Copy link
Member

jwulf commented Oct 24, 2024

Thanks for reporting this, and sorry that it is not working as expected.

I will be pushing a fix for this tomorrow.

jwulf added a commit that referenced this issue Oct 24, 2024
@jwulf
fix(modeler): correct HTTP methods for file methods.\nfixes #269
b059db9
jwulf added a commit that referenced this issue Oct 24, 2024
@jwulf
Merge pull request #271 from camunda/fix-269
864a507 
fix(modeler): correct HTTP methods for file methods. fixes #269
@jwulf jwulf closed this as completed in 7819baa Oct 24, 2024
jwulf added a commit that referenced this issue Oct 24, 2024
@jwulf
Merge pull request #272 from camunda/alpha
e72b6e3 
Fix #269
github-actions bot pushed a commit that referenced this issue Oct 24, 2024
@semantic-release-bot
chore(release): 8.6.15 [skip ci]
b04111f 
## [8.6.15](v8.6.14...v8.6.15) (2024-10-24)

### Bug Fixes

* **modeler:** correct HTTP methods for file methods. fixes [#269](#269) ([7819baa](7819baa))
github-actions bot pushed a commit that referenced this issue Oct 24, 2024
@semantic-release-bot
chore(release): 8.6.15 [skip ci]
1cb66f0 
## [8.6.15](v8.6.14...v8.6.15) (2024-10-24)

### Bug Fixes

* **modeler:** correct HTTP methods for file methods. fixes [#269](#269) ([7819baa](7819baa))
petar-slavov pushed a commit to petar-slavov/camunda-8-js-sdk that referenced this issue Mar 14, 2025
@semantic-release-bot @petar-slavov
chore(release): 8.6.15 [skip ci]
b974345 
## [8.6.15](camunda/camunda-8-js-sdk@v8.6.14...v8.6.15) (2024-10-24)

### Bug Fixes

* **modeler:** correct HTTP methods for file methods. fixes [camunda#269](camunda#269) ([7819baa](camunda@7819baa))
petar-slavov pushed a commit to petar-slavov/camunda-8-js-sdk that referenced this issue Mar 14, 2025
@semantic-release-bot @petar-slavov
chore(release): 8.6.15 [skip ci]
fcd23a8 
## [8.6.15](camunda/camunda-8-js-sdk@v8.6.14...v8.6.15) (2024-10-24)

### Bug Fixes

* **modeler:** correct HTTP methods for file methods. fixes [camunda#269](camunda#269) ([7819baa](camunda@7819baa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwulf jwulf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwulf @tijmenstor