Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polling when maxJobsToActivate is reached #406

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

petar-slavov
Copy link
Contributor

Fix a bug when currentlyActiveJobsCount = maxJobsToActivate, the client stops polling for new jobs.

Description of the change

Restart job polling if currentlyActiveJobsCount = maxJobsToActivate

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have opened this pull request against the alpha branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

[If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]

Sorry, something went wrong.

Fix a bug when currentlyActiveJobsCount = maxJobsToActivate, the client stops polling for new jobs.
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2025

CLA assistant check
All committers have signed the CLA.

@jwulf jwulf requested a review from Copilot March 17, 2025 00:17
@jwulf jwulf self-assigned this Mar 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the client stops polling for new jobs when the currently active job count reaches the maximum jobs to activate.

  • Reset the pollLock flag when the active job count meets or exceeds the maximum threshold.
  • Ensures the polling mechanism can resume after capacity is reached.

@jwulf
Copy link
Member

jwulf commented Mar 17, 2025

@petar-slavov thanks for this.

@jwulf jwulf merged commit eaa743b into camunda:alpha Mar 17, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants