This repository was archived by the owner on Mar 4, 2024. It is now read-only.
Add function calls for request lifecycle tracing #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
- Coverage 83.49% 82.95% -0.54%
==========================================
Files 49 50 +1
Lines 9280 8829 -451
Branches 2481 2215 -266
==========================================
- Hits 7748 7324 -424
+ Misses 974 857 -117
- Partials 558 648 +90
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We have to watch out a bit, e.g. |
|
Thanks, that's a good point about the ABI. I'll try removing the ID field and keying the bpftrace map on the other data that's already in the request struct; hopefully that should give enough uniqueness to work with until we're ready to implement real request IDs. |
Signed-off-by: Cole Miller <cole.miller@canonical.com>
This helps bpftrace generate stack traces. Signed-off-by: Cole Miller <cole.miller@canonical.com>
MathieuBordere
approved these changes
Oct 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two trivial functions,
lifecycleRequestStartandlifecycleRequestEnd, that are called when a request is put onto and taken off of the main request queue, respectively. By attaching bpftrace probes to these function calls, we can gather information about how long requests typically spend sitting on this queue. The function definitions are confined to a separate compilation unit to prevent inlining.