This repository was archived by the owner on Mar 4, 2024. It is now read-only.
tick: Don't convert to candidate while a snapshot is installing #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 84.08% 84.05% -0.04%
==========================================
Files 50 50
Lines 9454 9461 +7
Branches 2521 2525 +4
==========================================
+ Hits 7949 7952 +3
- Misses 934 935 +1
- Partials 571 574 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'll try to add a test for this. |
Looks good to me, a test would be nice indeed, you could mess with the IO latency and election timeout in the test to hit this case. |
cole-miller
force-pushed
the
convert
branch
2 times, most recently
from
c852bb8 to
6853f4f
Compare
|
Hmm, having a lot of trouble shortening the election timeout in the test to hit that new code path |
Got it! This should be ready to go. |
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343. @MathieuBordere, let me know if this wasn't what you had in mind, I'm sure there are other possible approaches.
Signed-off-by: Cole Miller cole.miller@canonical.com