Revert "replication: Drop append entries result if a state transition has occurred"

[cole-miller]

I believe that this fix is the cause of the new (and more frequent) Jepsen failures #355, so I'm reverting it until I understand what went wrong and can make another attempt to fix the original issue.

Reverts #351

[codecov]

Codecov Report

Merging #362 (1819829) into master (7a4a65a) will decrease coverage by 3.80%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   84.00%   80.19%   -3.81%     
==========================================
  Files          50       50              
  Lines        9464     8760     -704     
  Branches     2526     2463      -63     
==========================================
- Hits         7950     7025     -925     
- Misses        936      994      +58     
- Partials      578      741     +163     

Impacted Files	Coverage Δ
src/replication.c	73.22% <14.28%> (-4.27%)	⬇️
src/recv_timeout_now.c	46.42% <0.00%> (-20.24%)	⬇️
src/compress.c	54.54% <0.00%> (-15.96%)	⬇️
src/recv_request_vote_result.c	48.07% <0.00%> (-10.11%)	⬇️
src/uv_fs.c	62.58% <0.00%> (-9.56%)	⬇️
src/uv_list.c	71.15% <0.00%> (-9.55%)	⬇️
src/recv_request_vote.c	74.00% <0.00%> (-9.34%)	⬇️
src/recv_append_entries.c	70.49% <0.00%> (-9.20%)	⬇️
src/recv_install_snapshot.c	35.84% <0.00%> (-8.80%)	⬇️
src/recv_append_entries_result.c	71.42% <0.00%> (-8.58%)	⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.