gaps: fix gap size in extended #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbungert
force-pushed
the
lp-2015521-guided-resize-non-last-logical
branch
from
9b32362 to
f19500d
Compare
ogayot
reviewed
Apr 7, 2023
dbungert
force-pushed
the
lp-2015521-guided-resize-non-last-logical
branch
2 times, most recently
from
7a726b5 to
3b64d57
Compare
We need the ebr space if we're doing logical partitions, but not for the primaries.
dbungert
force-pushed
the
lp-2015521-guided-resize-non-last-logical
branch
from
3b64d57 to
5219ecf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gap sizing in extended had a flaw when there was a partition after it. We need the ebr space in between.
Emerged in the private bug LP: #2015521, where a user was given a guided resize option based on a logical partition that was not physically last. The result was that the end position of the newly created partition was the same spot as the offset of the next partition.