storage: don't let probing discard storage config in the middle of partitioning #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds correct but, as you mention, would bear significant testing. |
ogayot
commented
Apr 17, 2023
| @@ -772,16 +785,19 @@ async def v2_guided_GET(self, wait: bool = False) \ | |||
| async def v2_guided_POST(self, data: GuidedChoiceV2) \ | |||
| -> GuidedStorageResponseV2: | |||
| log.debug(data) | |||
| self.locked_probe_data = True | |||
There was a problem hiding this comment.
Maybe we load the probe data here too.
ogayot
force-pushed
the
no-probert-during-partitioning
branch
from
1f595e0 to
cf4e4fc
Compare
…rtitioning If a probert run finished in the middle of partitioning, the probing data would be loaded automatically and this would essentially discard changes made so far by the user. This is not a desirable behavior. Upon starting partitioning, we now prevent later probert runs from automatically loading the probe data. Instead, the data is stored and only loaded after after a reset. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
no-probert-during-partitioning
branch
from
cf4e4fc to
9e4cd77
Compare
|
I think at this point it's ready to review, but I want to run manual tests. |
dbungert
approved these changes
Apr 18, 2023
sil2100
reviewed
Apr 18, 2023
sil2100
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in the desktop installer with storage v2, things go bad if a probert storage run finishes during partitioning. Unless storage is already configured, we automatically discard any change done so far upon receiving a response from a probert storage run. This leads to various problems.
This PR aims at making sure the storage configuration is not reset by a probert run while we are in the middle of partitioning.
Essentially, any request that modifies the partitioning configuration will now ensure that a transaction is started. If we receive the result of a probert run in the middle of a transaction, the new data is not applied. Instead it is stored and will only be used if the user asks for a reset/refresh.
It also introduces a new endpoint storage/v2/ensure_transaction that a client can use before doing any modification to the partitioning configuration. This ensures that the data returned by a subsequent GET /storage/v2/ call will not be invalidated by a probert run.
TODO: