Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#1747] Event phases should be on both class and instance #1748

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: [#1747] Event phases should be on both class and instance #1748

merged 2 commits into from
Mar 4, 2025

Conversation

alan910127
Copy link
Contributor

Closes #1747.

capricorn86
capricorn86 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @alan910127! ⭐

@capricorn86 capricorn86 merged commit 0d1cbe0 into capricorn86:master Mar 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event phases should be on both class and instance
2 participants
@alan910127 @capricorn86