Add helm charts & build publish workflows #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
force-pushed
the
add-helm-chart-build-publish
branch
7 times, most recently
from
5273693 to
32f5656
Compare
terryyylim
force-pushed
the
add-helm-chart-build-publish
branch
from
cbf2631 to
0de81b5
Compare
terryyylim
commented
Jun 14, 2022
.github/workflows/tests.yml
Outdated
| @@ -1,182 +0,0 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Renamed file to xp.yml and added build/publish steps to new file.
| # - build-management-service | ||
| # - build-treatment-service | ||
| # - release-rules | ||
| # uses: gojek/xp/.github/workflows/release.yml@main |
There was a problem hiding this comment.
To uncomment release action in subsequent PR.
terryyylim
changed the title
krithika369
reviewed
Jun 17, 2022
.github/workflows/xp.yml
Outdated
| path: ui/build/ | ||
| retention-days: ${{ env.ARTIFACT_RETENTION_DAYS }} | ||
|
|
||
| build-management-service: |
There was a problem hiding this comment.
Can we combine this with the publish step ? In turing, the build / publish separation makes sense because the built docker images are used in the e2e tests. We don't need to build the docker images ahead of time for XP, right? The built API binaries from the e2e-tests job can be saved as artifacts for reuse. Then, during the publish phase, we can build the UI and subsequently use the API binaries in the docker image for the management service. Similar steps for the treatment service minus the UI.
terryyylim
force-pushed
the
add-helm-chart-build-publish
branch
from
42d7e0b to
52ad965
Compare
terryyylim
force-pushed
the
add-helm-chart-build-publish
branch
from
52ad965 to
047efe4
Compare
krithika369
reviewed
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds helm charts for both Management and Treatment Services. In addition, build and publish steps are added to Github Actions workflow for generation of the services' artifacts.
Which issue(s) this PR fixes:
NONE