Deprecate XP helm charts #72
Merged
+18
−1,375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
reviewed
Apr 21, 2023
krithika369
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
I just realised we are not testing XP with the chart in the CI/CD. 😅 So this turned out to be easier. But it also means that in the future, we will need to spend some time setting up the e2e with the docker images + chart. Anyway, that's out of scope of this task. I left one small comment. Thanks, @terryyylim !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
XP helm charts have been migrated to
caraml-devumbrella chart in the following PRs:As such, this PR deprecates the existing charts in this repository. Subsequently, https://github.com/turing-ml/charts will be archived once Turing helm charts have been deprecated too.
Which issue(s) this PR fixes:
NONE