Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial version of serialize test case #82

Merged
merged 3 commits into from
Apr 21, 2021
Merged

initial version of serialize test case #82

merged 3 commits into from
Apr 21, 2021

Conversation

ljj7975
Copy link
Member

@ljj7975 ljj7975 commented Apr 20, 2021 •
edited
Loading

Outline for #56

I didn't touch anything in serialize.py
except that one #TODO is added

# TODO:: process function should also take in sample (AudioClipExample)
#        and use sample.audio_data when metadata.path does not exist

Also, I only added the following line for base.py

# TODO:: id should be an explicit variable in order to support datasets creation with the audio data in memory

@ljj7975 ljj7975 requested review from daemon and edwinzhng April 20, 2021 03:11
@ljj7975 ljj7975 merged commit 4d7ebdc into master Apr 21, 2021
@ljj7975 ljj7975 deleted the serialize_test branch April 21, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daemon daemon daemon approved these changes

@edwinzhng edwinzhng Awaiting requested review from edwinzhng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljj7975 @daemon