Populate user subjects based on documents #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def index | ||
| redirect_to new_academic_history_path |
There was a problem hiding this comment.
Por que definis el index si el boton en el menu lleva al new? Se podria sacar?
frankete333
requested review from
EmilioCristalli,
RenzoMinelli and
santiagoguridi
| class PdfProcessor | ||
| include Enumerable | ||
|
|
||
| AcademicEntry = Struct.new(:name, :credits, :number_of_failures, :date_of_completion, :grade) do |
There was a problem hiding this comment.
Creo que deberias mover esto a una clase AcademicHistory::AcademicEntry luego en esa clase podes definir un metodo como save_academic_entry_to_user(user) y moves el codigo que dejaste en el controller para ahi.
Además, asi podemos hacer test sobre esa clase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-01-21.at.9.56.23.PM.mov