Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scraped subjects data #674

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update scraped subjects data #674

merged 1 commit into from
Mar 11, 2025

Conversation

mi-carrera-scraper[bot]
Copy link
Contributor

This PR runs to update scraped subjects' data

@RenzoMinelli RenzoMinelli requested a review from Copilot March 5, 2025 13:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates scraped subjects and their prerequisites data. The changes include adding new subject entries and updating the prerequisites logical structure for certain subjects.

  • New subjects '1158', '1275', and '1783' have been added with corresponding details in the subjects YAML file.
  • The prerequisites YAML file has been updated with new logical operator chains for subject codes '1158' and '1783'.

Reviewed Changes

File Description
db/data/scraped_subjects.yml Added three new subjects and updated the credits value for subject A66
db/data/scraped_prerequisites.yml Introduced new logical operator structures and updated subject prerequisite details

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

db/data/scraped_prerequisites.yml:6150

  • The subject_needed_code value '158Q' is not quoted, unlike similar values in the file; consider standardizing the quoting of subject codes to ensure consistency and proper parsing.
+      subject_needed_code: 158Q

@@ -2438,7 +2456,7 @@ A65:
A66:
code: A66
name: GESTIÓN DE PROYECTOS
credits: 10
credits: 5
Copy link
Preview

Copilot AI Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The credits value for subject A66 was changed from 10 to 5; please confirm that this reduction is intentional to avoid unintended downstream impact.

Suggested change
credits: 5
credits: 10

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@@ -2438,7 +2456,7 @@ A65:
A66:
code: A66
name: GESTIÓN DE PROYECTOS
credits: 10
credits: 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es real....

image

Esto es un problema, no? La gente que la aprobó antes cuando daba 10 ahora verían 5 créditos menos 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si creemos que puede ser un error, deberíamos reportarlo a bedelías.
Pero en mi opinión, si la pagina de bedelías dice 5 créditos, nosotros también deberíamos mostrar 5

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me gustaria ver la escolaridad de alguno que la haya hecho.

@santiagorodriguez96 santiagorodriguez96 merged commit 2d826d1 into master Mar 11, 2025
5 checks passed
@santiagorodriguez96 santiagorodriguez96 deleted the scraper branch March 11, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants