Fix failing system test #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `assert_text` inside `assert_emails` block to ensure the test waits for the controller to process the request before asserting email delivery. This prevents potential race conditions where the email might not be counted in time.
This way we ensures that the email field is present when we try to fill it.
This way we ensure that the review is created/updated
Error: ``` Failure: UserTest#test_can_sign_up [test/system/user_test.rb:47]: expected to find text "alice@test.com" in "menu\nMiCarrera\nsearch\ncloud_download\n0 créditos\nA\nBienvenido! Marcá los cursos y exámenes que aprobaste para ver qué materias podés cursar.\nLISTO\nBuilt by \nCedarcode". (However, it was found 1 time including non-visible text.) bin/rails test test/system/user_test.rb:9 ```
The test was failing with the following error:
```
Error:
UserTest#test_can_edit_profile:
Capybara::ElementNotFound: Unable to find visible link or button "Editar Perfil"
test/system/user_test.rb:135:in 'block in <class:UserTest>'
```
The issue is that there's a race condition between the application
loading the home page and capybara clicking on the user menu and it
having the `Editar Perfil` link. If capybara is too fast, it will click
on the user menu before the application loads so the click won't open
the menu and thus it won't find the button.
In order to fix this, we can wait until the text `Iniciaste sesión
correctamente` appears in the page, which will indicate when we can
continue with the rest of the actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.