Feature Request - DevToolsClient add strongly typed Events

[amaitland]

#3229 added support for calling DevTools methods in a strongly typed fashion.

• Add support for strongly typed EventArgs and classes to represent the params.

[amaitland]

I'm wondering if we might be able to simplify our event handling using a pattern similar to CefNet

• https://github.com/CefNet/CefNet.DevTools.Protocol/blob/dcab5e486d70b042ce0f0a81afc663f1325fdf6c/CefNet.DevTools.Protocol/Generated/WebAudio/WebAudioApi.g.cs#L61
• https://github.com/CefNet/CefNet.DevTools.Protocol/blob/0a124720474a469b5cef03839418f5e1debaf2f0/CefNet.DevTools.Protocol/CrdtpSession.cs#L24

[campersau]

This assumes that all event handlers for a specific eventName are of the same type.
https://github.com/CefNet/CefNet.DevTools.Protocol/blob/0a124720474a469b5cef03839418f5e1debaf2f0/CefNet.DevTools.Protocol/CrdtpSession.cs#L31

Currently we support multiple event handlers of different types for the same eventName. E.g.

devToolsClient.Network.RequestWillBeSent += (object sender, RequestWillBeSentEventArgs args) =>
{

};
devToolsClient.RegisterEventHandler("Network.requestWillBeSent", (object sender, DevToolsDomainEventArgsBase args) =>
{

});
devToolsClient.RegisterEventHandler("Network.requestWillBeSent", (object sender, MyRequestWillBeSentEventArgs args) =>
{

});

[DataContract]
private class MyRequestWillBeSentEventArgs : DevToolsDomainEventArgsBase
{

}

If we not only group event handlers by eventName but also by Type something like this might work. E.g. IDictionary<string, IDictionary<Type, IEventProxy>>
Or we declare that you can only add listeners for the same eventName of the same type as CefNet does.

(To be honest, I don't know how common it would be to use different types for the same eventName or even manually using RegisterEventHandler instead of the generated typed events.)

[ukandrewc]

Just a view: I came from WebView2, where there are no typed calls or events for DevTools. I have found the typed versions in CEFSharp to be very useful, so my vote would be for the same events typed as you have on the calls.

[amaitland]

Or we declare that you can only add listeners for the same eventName of the same type as CefNet does.

That was my original intention, this would greatly simplify our code. Keeping support for multiple types is of course possible, just not clear it's required.

(To be honest, I don't know how common it would be to use different types for the same eventName or even manually using RegisterEventHandler instead of the generated typed events.)

It seems like an edge case that would rarely if ever be used. Long as you can manually subscribe with your own type or use the built in event handler then I think that will be sufficient.

We can then look at cleaning up the event handlers on Dispose with the simplified design.

I have found the typed versions in CEFSharp to be very useful, so my vote would be for the same events typed as you have on the calls.

@ukandrewc If you are using the strongly typed events provided currently e.g. devToolsClient.Network.RequestWillBeSent then there will be no change. If you are manually calling devToolsClient.RegisterEventHandler then there will be no need to dispose of the returned IRegistration instance as RegisterEventHandler will return void.

If you are using multiple types for the same event as detailed by @campersau then that will no longer be supported.

[amaitland]

PR for proposed changes is #3777

Save approx 2000 lines of generated code.