feat: add naming per instance and delete by name #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port for individual instance names
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
| WebhookURL string `json:"webhook_url"` // Webhook URL of the job | ||
| Provider string `json:"provider"` // Provider of the compute service | ||
| Instances []DeleteInstance `json:"instances"` // Instances to delete | ||
| InstanceName string `json:"instance_name"` // Base name for instances |
There was a problem hiding this comment.
revisit how job names are being used
There was a problem hiding this comment.
should include job name as well
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
Comment on lines
+56
to
+57
| if r.InstanceName == "" { | ||
| return fmt.Errorf("instance_name is required") |
There was a problem hiding this comment.
I don't think this is required. revert to job name?
MSevey
commented
Mar 10, 2025
MSevey
commented
Mar 10, 2025
| @@ -99,18 +102,18 @@ func (s *InstanceService) DeleteInstance( | |||
| Model: gorm.Model{ | |||
| ID: jobID, | |||
| }, | |||
| Name: name, | |||
MSevey
commented
Mar 10, 2025
| ProjectName: projectName, | ||
| Status: models.JobStatusPending, | ||
| } | ||
|
|
||
| // Create infrastructure request | ||
| infraReq := &infrastructure.JobRequest{ | ||
| Name: name, |
There was a problem hiding this comment.
this should be additive and be job name as well
MSevey
commented
Mar 10, 2025
| Name: instance.Name, | ||
| ProjectName: infraReq.ProjectName, | ||
| Provider: infraReq.Provider, | ||
| InstanceName: instance.Name, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #76
Confirm the following:
Needs Followup
Job vs Instance naming
It appears that job names and instance names are being used interchangeably. This is going to cause confusion and lead to errors due to complexity building around the re-use.
These two fields need to be split out and kept separate.
Unit Testing
Some of the large functions should really be split out to allow for better unit testing that avoids unnecessary DB and API mocks.
Delete All
Seems like low hanging fruit to allow for delete all if no instances are provided. Should just enable that.
This would eliminate the need to be tracking deletions and creations to submit the exact number of delete requests needed.