Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CMake project #18

Closed
wants to merge 1 commit into from
Closed

Conversation

jejo86
Copy link

@jejo86 jejo86 commented Nov 6, 2021

CMake:
Updated the CMake project to work on latest Linuxes.
Dynamic creation of .desktop file on Linux.
Updated changelog file.
Removed dead code and old comments.

wxWidgets:
wxWidgets is searched for and if not found, downloaded and installed
automatically into the CMAKE_EP_BASE_PATH.

gettext:
The gettext dependency is downloaded and installed during CMake
configuration, if it is not found.
The project first searches for Gettext in the PATH environmental
variable.
Second, the CMAKE_EP_BASE_PATH is searched.
If not found, Gettext is automatically downloaded into the
CMAKE_EP_BASE_PATH folder.

Translations:
Translations are now found during development, as well as when
installed.

ReadMe:
Updated build instructions for Linux and Windows.
Details about dependencies and optional tools/arguments.

CMake:
Updated the CMake project to work on latest Linuxes.
Dynamic creation of `.desktop` file on Linux.
Updated changelog file.
Removed dead code and old comments.

wxWidgets:
wxWidgets is searched for and if not found, downloaded and installed
automatically into the `CMAKE_EP_BASE_PATH`.

gettext:
The gettext dependency is downloaded and installed during CMake
configuration, if it is not found.
The project first searches for `Gettext` in the `PATH` environmental
variable.
Second, the `CMAKE_EP_BASE_PATH` is searched.
If not found, `Gettext` is automatically downloaded into the
`CMAKE_EP_BASE_PATH` folder.

Translations:
Translations are now found during development, as well as when
installed.

ReadMe:
Updated build instructions for Linux and Windows.
Details about dependencies and optional tools/arguments.
@jejo86
Copy link
Author

jejo86 commented Nov 6, 2021

This pull request primarily fixes wxMP3gain to be buildable/usable under the latest Ubuntu / Linux Mint versions.

Unfortunately though, I could not get the main icon icon-app.ico to be loaded correctly.

@cfgnunes cfgnunes deleted the branch cfgnunes:master December 29, 2021 12:43
@cfgnunes cfgnunes closed this Dec 29, 2021
@cfgnunes
Copy link
Owner

cfgnunes commented Jul 27, 2022

@jejo86 sorry for delay in answering.

Thank you so much for your contributions!
Unfortunately, the pull request was closed because I changed the branch 'master' to 'main'. Also, the structure of the code changed a bit.

But I'll include your modifications to the code coming soon.

@jejo86
Copy link
Author

jejo86 commented Aug 2, 2022

Sure thing. I hope you can make use of the changes. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants