This repository was archived by the owner on Jul 2, 2021. It is now read-only.
Add vis instance segmentation func #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
knorth55
force-pushed
the
add-vis-instance-segmentation
branch
from
8019556 to
59604e2
Compare
knorth55
force-pushed
the
add-vis-instance-segmentation
branch
from
59604e2 to
7b14cfa
Compare
knorth55
force-pushed
the
add-vis-instance-segmentation
branch
4 times, most recently
from
2003d55 to
10d8d69
Compare
yuyu2172
reviewed
Mar 26, 2018
| if score is not None and not len(bbox) == len(score): | ||
| raise ValueError('The length of score must be same as that of bbox') | ||
|
|
||
| n_ins_class = len(bbox) |
There was a problem hiding this comment.
s/n_ins_class/n_inst
n_ins_class sounds like this is related to class categories.
| raise ValueError('The length of score must be same as that of bbox') | ||
|
|
||
| n_ins_class = len(bbox) | ||
| colors = [_default_cmap(l) for l in range(n_ins_class + 1)] |
There was a problem hiding this comment.
How about range(1, n_inst)?
By doing so, you can remove one line.
Also, np.array is optional in this case, so we can omit it.
| if label is not None and not len(bbox) == len(label): | ||
| raise ValueError('The length of label must be same as that of bbox') | ||
| if score is not None and not len(bbox) == len(score): | ||
| raise ValueError('The length of score must be same as that of bbox') |
There was a problem hiding this comment.
How about checking mask as well?
| # Returns newly instantiated matplotlib.axes.Axes object if ax is None | ||
| ax = vis_image(img, ax=ax) | ||
|
|
||
| vis_img = np.zeros((mask.shape[1], mask.shape[2], 4), dtype=np.uint8) |
There was a problem hiding this comment.
vis_img has very similar name to vis_image.
How about canvas?
| This is in RGB format and the range of its value is | ||
| :math:`[0, 255]`. | ||
| bbox (~numpy.ndarray): A float array of shape :math:`(R, 4)`. | ||
| R is the number of objects in the image, and each vector |
| >>> from chainercv.datasets import SBDInstanceSegmentationDataset | ||
| >>> from chainercv.datasets \ | ||
| ... import sbd_instance_segmentation_label_names | ||
| >>> from chainercv.visualizations import vis_image |
knorth55
force-pushed
the
add-vis-instance-segmentation
branch
from
10d8d69 to
0b934de
Compare
|
Please rebase master |
knorth55
force-pushed
the
add-vis-instance-segmentation
branch
2 times, most recently
from
705e2fd to
f53bc22
Compare
|
i rebased and updated |
yuyu2172
reviewed
Mar 26, 2018
| :obj:`label_names`. | ||
| label_names (iterable of strings): Name of labels ordered according | ||
| to label ids. | ||
| alpha (float): The value which determines transparency of the figure. |
There was a problem hiding this comment.
Is alpha=1 a reasonable default value?
To me, alpha=0.7 looks better.
Also, the doc needs to be changed if we are changing this.
There was a problem hiding this comment.
I prefer alpha=0.7, so I will change it
knorth55
force-pushed
the
add-vis-instance-segmentation
branch
from
f53bc22 to
d163005
Compare
yuyu2172
approved these changes
Mar 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #540
vis_instance_segmentationtest_vis_instance_segmentation_dataset.py