This repository was archived by the owner on Jul 2, 2021. It is now read-only.
Support keys assign in GetterDataset #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
yuyu2172
reviewed
Apr 18, 2018
| for key in keys: | ||
| if isinstance(key, int): | ||
| key_index = key | ||
| if key_index >= len(self._keys): |
There was a problem hiding this comment.
How about
if key_index < 0:
key_index += len(self._keys)
if key_index >= len(self._keys) or key_index < 0:
raise IndexError('index {} is out of bounds for keys with size {}'.format(key, len(self._keys))
There was a problem hiding this comment.
The error message would be similar to NumPy.
yuyu2172
approved these changes
Apr 18, 2018
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from #457