Skip to content

Commit 371bd81

Browse files
committed
[1.10>master] [MERGE #5533 @MSLaguana] Removing assert/special casing of javascript proxy queryObjectInterface
Merge pull request #5533 from MSLaguana:removeProxyComSpecialCase JavaScript Proxies don't support any COM interfaces; but neither does RecyclableObject, and that doesn't assert. The default handling should be correct in this case. Fixes OS:16539184
2 parents c691359 + ac99d70 commit 371bd81

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/Runtime/Library/JavascriptProxy.h

-4
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ namespace Js
145145
BOOL SetPrototypeTrap(RecyclableObject* newPrototype, bool showThrow, ScriptContext * requestContext);
146146
Var ToString(Js::ScriptContext* scriptContext);
147147

148-
// proxy does not support IDispatch stuff.
149-
virtual Var GetNamespaceParent(Js::Var aChild) { AssertMsg(false, "Shouldn't call this implementation."); return nullptr; }
150-
virtual HRESULT QueryObjectInterface(REFIID riid, void **ppvObj) { AssertMsg(false, "Shouldn't call this implementation."); return E_NOTIMPL; }
151-
152148
virtual BOOL GetDiagTypeString(StringBuilder<ArenaAllocator>* stringBuilder, ScriptContext* requestContext) override;
153149
virtual RecyclableObject* ToObject(ScriptContext * requestContext) override;
154150
virtual Var GetTypeOfString(ScriptContext* requestContext) override;

0 commit comments

Comments
 (0)