Removing assert/special casing of javascript proxy queryObjectInterface #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtisman
reviewed
Jul 26, 2018
| @@ -147,7 +147,6 @@ namespace Js | |||
|
|
|||
| // proxy does not support IDispatch stuff. | |||
| virtual Var GetNamespaceParent(Js::Var aChild) { AssertMsg(false, "Shouldn't call this implementation."); return nullptr; } | |||
There was a problem hiding this comment.
Should we remove this one as well?
There was a problem hiding this comment.
That seems reasonable, since RecyclableObject has the same return nullptr behavior, and nothing else overrides it.
MSLaguana
force-pushed
the
removeProxyComSpecialCase
branch
from
9c10927 to
230070b
Compare
curtisman
approved these changes
Jul 26, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jul 26, 2018
… proxy queryObjectInterface Merge pull request #5533 from MSLaguana:removeProxyComSpecialCase JavaScript Proxies don't support any COM interfaces; but neither does RecyclableObject, and that doesn't assert. The default handling should be correct in this case. Fixes OS:16539184
chakrabot
pushed a commit
that referenced
this pull request
Jul 26, 2018
… of javascript proxy queryObjectInterface Merge pull request #5533 from MSLaguana:removeProxyComSpecialCase JavaScript Proxies don't support any COM interfaces; but neither does RecyclableObject, and that doesn't assert. The default handling should be correct in this case. Fixes OS:16539184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript Proxies don't support any COM interfaces; but neither does RecyclableObject, and that doesn't assert. The default handling should be correct in this case.
Fixes OS:16539184