Fixes #5576 - Chakra should not redeclare "undefined" keyword #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyrichte
force-pushed
the
build/wyrichte/5576_1
branch
from
4ad22f4 to
5558c3d
Compare
wyrichte
force-pushed
the
build/wyrichte/5576_1
branch
from
5558c3d to
3a65aa7
Compare
dilijev
reviewed
Oct 1, 2018
lib/Parser/perrors.h
Outdated
| LSC_ERROR_MSG( 1015, ERRnoStrEnd , "Unterminated string constant") | ||
| LSC_ERROR_MSG( 1016, ERRnoCmtEnd , "Unterminated comment") | ||
| LSC_ERROR_MSG( 1017, ERRIdAfterLit , "Unexpected identifier after numeric literal") | ||
| LSC_ERROR_MSG(1004, ERRnoSemic, "Expected ';'") |
There was a problem hiding this comment.
nit: Can you revert the formatting changes that were made to this file?
dilijev
reviewed
Oct 1, 2018
dilijev
approved these changes
Oct 1, 2018
dilijev
added
the
Bytecode-Update
sethbrenith
reviewed
Oct 1, 2018
lib/Runtime/Types/RecyclableObject.h
Outdated
| @@ -313,6 +313,7 @@ namespace Js { | |||
| virtual BOOL InitPropertyInEval(PropertyId propertyId, Var value, PropertyOperationFlags flags = PropertyOperation_None, PropertyValueInfo* info = NULL); | |||
| virtual BOOL EnsureProperty(PropertyId propertyId); | |||
| virtual BOOL EnsureNoRedeclProperty(PropertyId propertyId); | |||
| virtual BOOL EnsureNoRedeclFunc(PropertyId propertyId); | |||
There was a problem hiding this comment.
I see that you're following the pattern of EnsureNoRedeclProperty, but I don't think the pattern should necessarily apply, because EnsureNoRedeclProperty is used in a much bigger variety of ways.
- Why does this have a return value? As far as I can tell, the returned value is never used.
- Why is this virtual and defined on RecyclableObject? The only call site knows that the type will be RootObjectBase; can't we just cast directly to that and call a non-virtual method?
wyrichte
force-pushed
the
build/wyrichte/5576_1
branch
3 times, most recently
from
bb944f9 to
66e1d2d
Compare
…ord. Fixed by adding opcode OP_EnsureNoRootRedeclFunc that enforces the section of #sec-globaldeclarationinstantiation where #CanDeclareGlobalFunction is called. This enforces that when a global function that is not configurable, not writable, and not enumerable is overwritten a TypeError is thrown.
wyrichte
force-pushed
the
build/wyrichte/5576_1
branch
from
66e1d2d to
8ecdb9e
Compare
chakrabot
pushed a commit
that referenced
this pull request
Oct 2, 2018
…defined" keyword Merge pull request #5734 from wyrichte:build/wyrichte/5576_1 Fixed by adding opcode OP_EnsureNoRootRedeclFunc that enforces the section of #sec-globaldeclarationinstantiation where #CanDeclareGlobalFunction is called. This enforces that when a global function that is not configurable, not writable, and not enumerable is overwritten a TypeError is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by adding opcode OP_EnsureNoRootRedeclFunc that enforces the section of #sec-globaldeclarationinstantiation where #CanDeclareGlobalFunction is called. This enforces that when a global function that is not configurable, not writable, and not enumerable is overwritten a TypeError is thrown.