Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the error code related to the container name #27

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Jul 1, 2021

Signed-off-by: xcaspar changjun.xcj@alibaba-inc.com

Describe what this PR does / why we need it

chaosblade-io/chaosblade#522

Does this pull request fix one issue?

Describe how you did it

Add --container-name to specify the container for solving the container id conversion problem.

Describe how to verify it

// right container name
blade c docker network dns --container-name tender_mccar --ip 10.10.10.10 --domain fortesting

// error container name
blade c docker network dns --container-name sssss --ip 10.10.10.10 --domain fortesting

// destroy experiment using uid
blade d 8bd050ee6ff8ad90 

// destroy experiment without uid
blade d docker network dns --container-name tender_mccar --ip 10.10.10.10 --domain fortesting

Special notes for reviews

Signed-off-by: xcaspar <changjun.xcj@alibaba-inc.com>
@xcaspar xcaspar added this to the v1.3.0 milestone Jul 1, 2021
@xcaspar xcaspar requested a review from MandssS July 1, 2021 08:01
@MandssS MandssS merged commit 51f1ccd into v1.3.0-dev Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants