Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new way of process search #32

Merged
merged 1 commit into from
Sep 6, 2021
Merged

add new way of process search #32

merged 1 commit into from
Sep 6, 2021

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Sep 6, 2021

Signed-off-by: xcaspar changjun.xcj@alibaba-inc.com

Describe what this PR does / why we need it

Support to specify the process name and process keyword at the same time to find the process.

For example, we need to specify the Java process that contains the recomendationservice keyword to attach java agent.

/app # ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 Aug23 ?        00:00:39 /sbin/tini -s -- java -jar /app/recomendationservice-provider-0.0.1-SNAPSHOT.jar
root           8       1  3 Aug23 ?        11:12:16 java -jar /app/recomendationservice-provider-0.0.1-SNAPSHOT.jar
root         368       0  0 Aug23 pts/0    00:00:00 sh
root       16298       0  0 06:41 pts/1    00:00:00 sh
root       16305   16298  0 06:41 pts/1    00:00:00 ps -ef

Does this pull request fix one issue?

Describe how you did it

Add ProcessCommandKey to specify the process command name.

Describe how to verify it

Special notes for reviews

Signed-off-by: xcaspar <changjun.xcj@alibaba-inc.com>
@xcaspar xcaspar requested a review from MandssS September 6, 2021 06:52
@xcaspar xcaspar changed the base branch from master to 1.4.0-dev September 6, 2021 06:52
@xcaspar xcaspar added this to the v1.4.0 milestone Sep 6, 2021
@MandssS MandssS merged commit ae22844 into 1.4.0-dev Sep 6, 2021
@xcaspar xcaspar deleted the process-search branch September 6, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants