feature: change jvm sandbox default namespace #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangle
force-pushed
the
change-sandbox-namespace
branch
from
3034d16 to
60b7cbd
Compare
Signed-off-by: orangle <orangleliu@gmail.com>
orangle
force-pushed
the
change-sandbox-namespace
branch
from
60b7cbd to
29b63dd
Compare
xcaspar
approved these changes
Jul 5, 2021
|
Yes, it should be changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
when we use chaosblade(chaosblade-exec-jvm) and jvm-sandbox-repeater same time, there is a namespace conflict, which makes it unavailable. Because the default namespace of the two agents is "default", I want to modify the "default"namespace.
Does this pull request fix one issue?
Describe how you did it
change chaosblade-exec-jvm default namespace from "default" to "chaosblade"
Describe how to verify it
Special notes for reviews