Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phi #169

Merged
merged 17 commits into from
May 15, 2024
Merged

Phi #169

merged 17 commits into from
May 15, 2024

Conversation

pevnak
Copy link
Contributor

@pevnak pevnak commented Jan 30, 2024

This is a follower of pull-request #168. It contains those changes adding phi models and I have also added a rudimentary support of loading safetensors. I can make a proper repository for SafeTensors if needed, but this is a quick fix.
I have tested phi_1, phi_1_5 and phi_2 (for which I need safetensors) to the python version and outputs of all intermediate layers are equal

@chengchingwen
Copy link
Owner

I can make a proper repository for SafeTensors if needed

That would be better

@pevnak
Copy link
Contributor Author

pevnak commented Feb 6, 2024

The package SafeTensors.jl will be registered in 3 days and then I will finish this.

@pevnak
Copy link
Contributor Author

pevnak commented Feb 13, 2024

It should be fine now. SafeTensors library is registered and and I have uncommented test of the phi model.

@pevnak pevnak mentioned this pull request Feb 13, 2024
pevnak and others added 9 commits February 17, 2024 12:37
Co-authored-by: Peter <adgjl5645@hotmail.com>
Co-authored-by: Peter <adgjl5645@hotmail.com>
Co-authored-by: Peter <adgjl5645@hotmail.com>
Co-authored-by: Peter <adgjl5645@hotmail.com>
Co-authored-by: Peter <adgjl5645@hotmail.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 59.07692% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 47.82%. Comparing base (91a3fe0) to head (3bb4a58).

Files Patch % Lines
src/device.jl 0.00% 72 Missing ⚠️
src/huggingface/weight.jl 58.53% 34 Missing ⚠️
src/huggingface/implementation/phi/load.jl 91.24% 12 Missing ⚠️
src/huggingface/implementation/llama/attention.jl 0.00% 5 Missing ⚠️
src/huggingface/implementation/llama/load.jl 0.00% 3 Missing ⚠️
src/huggingface/download.jl 0.00% 2 Missing ⚠️
ext/TransformersAMDGPUExt/TransformersAMDGPUExt.jl 0.00% 1 Missing ⚠️
ext/TransformersCUDAExt/TransformersCUDAExt.jl 0.00% 1 Missing ⚠️
ext/TransformersMetalExt/TransformersMetalExt.jl 0.00% 1 Missing ⚠️
src/huggingface/implementation/phi/config.jl 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   46.52%   47.82%   +1.29%     
==========================================
  Files          85       90       +5     
  Lines        4400     4659     +259     
==========================================
+ Hits         2047     2228     +181     
- Misses       2353     2431      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengchingwen chengchingwen changed the base branch from master to 0.3 May 15, 2024 00:18
@chengchingwen chengchingwen merged commit 5d765ab into chengchingwen:0.3 May 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants