Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing expiring key for integration builder #425

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fix missing expiring key for integration builder #425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97ef3ba
Fix missing exipiring value
GDay Feb 8, 2024
38be101
renew key
GDay Feb 8, 2024
af992cf
Fix black
GDay Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions back/admin/integrations/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,19 +336,25 @@ def post(self, request, *args, **kwargs):
return HttpResponse(f"Data of request {idx + 1} is not a valid json")

extra_args_dict = {item["key"]: item["value"] for item in extra_args}
expiring = timezone.now()

try:
extra_args_dict |= Integration.objects.get(
integration = Integration.objects.get(
id=request.POST.get("integration_id", -1)
).extra_args
)
integration.renew_key()
extra_args_dict |= integration.extra_args
expiring = integration.expiring
except Integration.DoesNotExist:
# don't use args from original manifest
pass

# mock extra fields to user. DO NOT SAVE!
extra_fields_dict = {item["key"]: item["value"] for item in extra_fields}
user.extra_fields = extra_fields_dict
integration = Integration(manifest=manifest, extra_args=extra_args_dict)
integration = Integration(
manifest=manifest, extra_args=extra_args_dict, expiring=expiring
)

if test_type == "form":
form = integration.config_form()
Expand Down
Loading