actionTypes: Make subscriptions[] exact on `EventSubscriptionRemove…

…Action`. The doc, at https://zulip.com/api/get-events, suggests that this type already includes all fields that will be present. So, make it exact. An instance of zulip#3452.
chrisbobbe · Mar 12, 2021 · 2f5fe9c · 2f5fe9c
1 parent 1680622
commit 2f5fe9c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/actionTypes.js b/src/actionTypes.js
@@ -264,10 +264,10 @@ type EventSubscriptionRemoveAction = {|
   ...ServerEvent,
   type: typeof EVENT_SUBSCRIPTION,
   op: 'remove',
-  subscriptions: Array<{
+  subscriptions: Array<{|
     name: string,
     stream_id: number,
-  }>,
+  |}>,
 |};
 
 type EventSubscriptionUpdateAction = {|

diff --git a/src/subscriptions/__tests__/subscriptionsReducer-test.js b/src/subscriptions/__tests__/subscriptionsReducer-test.js
@@ -97,7 +97,10 @@ describe('subscriptionsReducer', () => {
         type: EVENT_SUBSCRIPTION,
         op: 'remove',
         id: 1,
-        subscriptions: [sub1, sub2],
+        subscriptions: [
+          { name: sub1.name, stream_id: sub1.stream_id },
+          { name: sub2.name, stream_id: sub2.stream_id },
+        ],
       });
 
       const expectedState = [sub3];
@@ -114,7 +117,10 @@ describe('subscriptionsReducer', () => {
         type: EVENT_SUBSCRIPTION,
         op: 'remove',
         id: 1,
-        subscriptions: [sub1, sub2],
+        subscriptions: [
+          { name: sub1.name, stream_id: sub1.stream_id },
+          { name: sub2.name, stream_id: sub2.stream_id },
+        ],
       });
 
       const expectedState = [];