Use no_std-compatible num dependencies #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than the `num` meta-crate, use `num-integer` and `num-traits` without default features to make them `#[no_std]`. `num-iter` is just a dev-dependency now for a few test cases. The only public change is the `impl FromPrimitive for Weekday`, but this is still the same exact trait that `num` re-exports, so this is not a breaking change.
|
I saw that #195 was contemplating no-std support. |
|
Yup since the std feature has no effect on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than the
nummeta-crate, usenum-integerandnum-traitswithout default features to make them
#[no_std].num-iterisjust a dev-dependency now for a few test cases.
The only public change is the
impl FromPrimitive for Weekday, but thisis still the same exact trait that
numre-exports, so this is not abreaking change.