uninstall: set "cni.uninstall" to true on uninstall #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
force-pushed
the
enable-cni-uninstall
branch
from
0297673 to
6eac187
Compare
rolinh
approved these changes
Mar 15, 2023
There is a Helm variable, `cni.uninstall`, that tells the agent to clean up its CNI configuration file and plugin binaries. This behavior was disabled by default in PR cilium/cilium#24009. However, when we *know* we're uninstalling Cilium, we should re-enable the old behavior. So, manually touch the key file in the configmap to enable uninstall. Then, the pre-stop hook will be activated on shutdown and clean up as usual. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
squeed
force-pushed
the
enable-cni-uninstall
branch
from
6eac187 to
d9c1c15
Compare
|
@kaworu thanks for the review, updated! |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a Helm variable,
cni.uninstall, that tells the agent to clean up its CNI configuration file and plugin binaries. This behavior was disabled by default in PR cilium/cilium#24009. However, when we know we're uninstalling Cilium, we should re-enable the old behavior.So, manually touch the key file in the configmap to enable uninstall. Then, the pre-stop hook will be activated on shutdown and clean up as usual.