Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity: Extend pod-to-pod encryption tests (for WG) #2409

Merged
merged 1 commit into from
Jun 18, 2024
Merged

connectivity: Extend pod-to-pod encryption tests (for WG) #2409

merged 1 commit into from
Jun 18, 2024

Conversation

brb
Copy link
Member

@brb brb commented Mar 14, 2024 •
edited
Loading

CI run cilium/cilium#32995. Only for WG (see cilium/cilium#33168 for IPsec issues).

@brb brb requested a review from giorio94 March 14, 2024 07:48
@brb brb requested review from a team as code owners March 14, 2024 07:48
@brb brb requested review from jschwinger233 and tklauser March 14, 2024 07:48
giorio94
giorio94 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Just one comment inline.

@brb brb marked this pull request as draft March 14, 2024 10:59
@julianwiedmann
Copy link
Member

@brb want to give this another try, now that cilium/cilium#32683 is in? :)

@brb
Copy link
Member Author

brb commented Jun 10, 2024

Oh! Yep, let's try 🤞

@brb brb force-pushed the pr/brb/tmp-ci branch from d2b94b7 to 5401ce3 Compare June 10, 2024 06:43
@brb
Copy link
Member Author

brb commented Jun 11, 2024

Unfortunately, the new test failed with IPsec enabled :-( cilium/cilium#32995

@brb
Copy link
Member Author

brb commented Jun 11, 2024

MBOI @jschwinger233 ^^

@brb
connectivity: Extend pod-to-pod encryption tests
dd8fae8 
Add L7 policy checks. Only for WG, while IPsec is currently suffering
from cilium/cilium#33168.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/tmp-ci branch from 5401ce3 to dd8fae8 Compare June 17, 2024 07:45
@brb brb marked this pull request as ready for review June 17, 2024 09:42
@brb brb requested a review from jschwinger233 June 17, 2024 09:42
@brb brb changed the title connectivity: Extend pod-to-pod encryption tests connectivity: Extend pod-to-pod encryption tests (for WG) Jun 17, 2024
@brb
Copy link
Member Author

brb commented Jun 17, 2024

@julianwiedmann Unfortunately, the test case is for WG only at least for now.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 18, 2024
@michi-covalent michi-covalent merged commit cf4696f into main Jun 18, 2024
14 of 15 checks passed
@michi-covalent michi-covalent deleted the pr/brb/tmp-ci branch June 18, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brb @julianwiedmann @tklauser @jschwinger233 @giorio94 @michi-covalent