-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renovate config migration remake #2915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's no longer part of the Dockerfile, hence does nothing. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Since the move of the code to cilium/cilium this file doesn't exist anymore. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
tklauser
reviewed
Jan 22, 2025
These are only indirect dependencies now, no need for special handling. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Formatter used is https://github.com/google/json5format/, as below. $ formatjson5 -i 2 renovate.json5 This gets us closer to what renovate produces. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
These are the actual changes to the schema, as gleaned from the messy diff of #2913. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
d69f2c3
to
db05e76
Compare
tklauser
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up and splitting it up into nicely documented individual commits!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the same as #2913 but done by hand and split into understandable commits.
I've also taken the liberty of dropping a few unused things from the config, that's the first couple of commits.