Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate config migration remake #2915

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

bimmlerd
Copy link
Member

@bimmlerd bimmlerd commented Jan 22, 2025

This is mostly the same as #2913 but done by hand and split into understandable commits.

I've also taken the liberty of dropping a few unused things from the config, that's the first couple of commits.

It's no longer part of the Dockerfile, hence does nothing.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Since the move of the code to cilium/cilium this file doesn't exist anymore.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
@bimmlerd bimmlerd requested a review from a team as a code owner January 22, 2025 12:17
@bimmlerd bimmlerd requested a review from tklauser January 22, 2025 12:17
@bimmlerd bimmlerd changed the title renovate config migratio remake renovate config migration remake Jan 22, 2025
These are only indirect dependencies now, no need for special handling.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Formatter used is https://github.com/google/json5format/, as below.

$ formatjson5 -i 2 renovate.json5

This gets us closer to what renovate produces.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
These are the actual changes to the schema, as gleaned from the messy
diff of #2913.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
@bimmlerd bimmlerd force-pushed the pr/bimmlerd/renovate-config-migratio-remake branch from d69f2c3 to db05e76 Compare January 22, 2025 12:45
@bimmlerd bimmlerd requested a review from tklauser January 22, 2025 12:45
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up and splitting it up into nicely documented individual commits!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 22, 2025
@tklauser tklauser merged commit 9791ab5 into main Jan 22, 2025
14 checks passed
@tklauser tklauser deleted the pr/bimmlerd/renovate-config-migratio-remake branch January 22, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants