action: Clean up the logic to handle go-mod-directory #2956
+7
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/partial-revert
branch
from
c705477 to
6a150b8
Compare
- Partially revert commit cc1a61d [^1] since Cilium updated the Go version to 1.24 in main branch [^2]. - Change the default go-mod-directory to the top-level directory to match the current code structure in cilium/cilium where go.mod file is only in the top-level directory. - Set setup-go cache-dependency-path parameter to '**/go.sum' so that caching works regardless of how go-mod-directory parameter is set. [^1]: #2871 [^2]: cilium/cilium#37852 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/partial-revert
branch
from
6a150b8 to
a0ab6a4
Compare
tklauser
approved these changes
Feb 28, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
that referenced
this pull request
Feb 28, 2025
Bumping up the minor version to indicate that there is a behavior change in cilium-cli GitHub Action [^1]. [^1]: #2956 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Feb 28, 2025
Bumping up the minor version to indicate that there is a behavior change in cilium-cli GitHub Action [^1]. [^1]: #2956 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Mar 1, 2025
Bumping up the minor version to indicate that there is a behavior change in cilium-cli GitHub Action [^1]. [^1]: #2956 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Mar 1, 2025
Bumping up the minor version to indicate that there is a behavior change in cilium-cli GitHub Action [^1]. [^1]: #2956 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footnotes
https://github.com/cilium/cilium-cli/pull/2871 ↩
https://github.com/cilium/cilium/pull/37852 ↩