-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance #64
Maintenance #64
Conversation
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🥳 , please look at the comments I left before things can get merged.
Co-authored-by: Eileen Kuehn <eileen.kuehn@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
…runtime-eval into maintenance Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Co-authored-by: Eileen Kuehn <eileen.kuehn@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
…runtime-eval into maintenance
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly done, just three very small changes and then you are good to go 👍
Co-authored-by: Eileen Kuehn <eileen.kuehn@kit.edu>
Co-authored-by: Eileen Kuehn <eileen.kuehn@kit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR bumps all fws to the latest version (including missing packages in
requirements.in
) (resolves #66) and contains some rework of theREADME.md
(resolves #65 )