Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): PNRN-43 add user profile edit #17

Merged
merged 2 commits into from
Sep 5, 2022
Merged

feat(settings): PNRN-43 add user profile edit #17

merged 2 commits into from
Sep 5, 2022

Conversation

noice-noise
Copy link
Contributor

@noice-noise noice-noise commented Sep 5, 2022 •
edited
Loading

Description

  • Add user edit profile through Settings
  • Minor improvements on Account Edit

Checklist

First, create a draft pull request. Then mark the PR as ready for review when all necessary checkbox items has been completed

  • Reviewed own code
  • Commented on code that is hard to understand
  • Implemented tests for the feature/bugfix
  • All GitHub status checks pass
  • The frontend and backend PR previews have been deployed

Backend only

  • Added test data for new entity
  • Generated the client api if there are new or deleted endpoints and/or DTOs

@vercel
Copy link

vercel bot commented Sep 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pnrn-pnrn ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 0:16AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
pnrn-pnrn-staging ⬜️ Ignored (Inspect) Sep 5, 2022 at 0:16AM (UTC)

@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-17 September 5, 2022 08:57 Inactive
@noice-noise noice-noise force-pushed the feat/PNRN-43-user-info-edit branch from 835c017 to 0cb84ec Compare September 5, 2022 10:01
@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-17 September 5, 2022 10:01 Inactive
noice-noise
noice-noise commented Sep 5, 2022
View reviewed changes
frontend/src/modules/accounts/components/AccountEditForm.tsx
<FormikResetEffect
dependencies={[mutation]}
condition={mutation.isError}
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed FormikResetEffect component, as the Clear Input button is enough in this case. #naolenough

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💔

@noice-noise noice-noise force-pushed the feat/PNRN-43-user-info-edit branch from 0cb84ec to e88c6f6 Compare September 5, 2022 10:29
@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-17 September 5, 2022 10:30 Inactive
@noice-noise noice-noise marked this pull request as ready for review September 5, 2022 10:35
@noice-noise noice-noise requested a review from a team as a code owner September 5, 2022 10:35
princhcanal
princhcanal approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@princhcanal princhcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes!

#morethanenough rasad ka ra0l 💜

frontend/src/modules/accounts/components/AccountEditForm.tsx
<FormikResetEffect
dependencies={[mutation]}
condition={mutation.isError}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💔

beefysalad
beefysalad approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@beefysalad beefysalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-17 September 5, 2022 12:16 Inactive
@noice-noise noice-noise merged commit 93b0aab into dev Sep 5, 2022
@noice-noise noice-noise deleted the feat/PNRN-43-user-info-edit branch September 5, 2022 12:23
@noice-noise noice-noise self-assigned this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princhcanal princhcanal princhcanal approved these changes

@beefysalad beefysalad beefysalad approved these changes

@junix033101 junix033101 Awaiting requested review from junix033101 junix033101 is a code owner automatically assigned from citu-cpe/pnrn

Assignees

@noice-noise noice-noise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noice-noise @princhcanal @beefysalad