Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(organizer): PNRN-40 organizer test for all request routes #22

Merged
merged 3 commits into from
Sep 6, 2022
Merged

test(organizer): PNRN-40 organizer test for all request routes #22

merged 3 commits into from
Sep 6, 2022

Conversation

junix033101
Copy link
Contributor

@junix033101 junix033101 commented Sep 6, 2022 •
edited
Loading

Description

Provide a description on what was changed/added/fixed in this PR

Checklist

First, create a draft pull request. Then mark the PR as ready for review when all necessary checkbox items has been completed

  • Reviewed own code
  • Commented on code that is hard to understand
  • Implemented tests for the feature/bugfix
  • All GitHub status checks pass
  • The frontend and backend PR previews have been deployed

Backend only

  • Added test data for new entity
  • Generated the client api if there are new or deleted endpoints and/or DTOs

@vercel
Copy link

vercel bot commented Sep 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pnrn-pnrn ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 7:52AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
pnrn-pnrn-staging ⬜️ Ignored (Inspect) Sep 6, 2022 at 7:52AM (UTC)

@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-22 September 6, 2022 07:01 Inactive
@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-22 September 6, 2022 07:03 Inactive
@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-22 September 6, 2022 07:52 Inactive
@junix033101 junix033101 marked this pull request as ready for review September 6, 2022 07:52
@junix033101 junix033101 requested a review from a team as a code owner September 6, 2022 07:52
@junix033101 junix033101 merged commit ecbd817 into dev Sep 6, 2022
@junix033101 junix033101 deleted the test/PNRN-40-organizer-CRUD-test branch September 6, 2022 08:02
princhcanal
princhcanal reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@princhcanal princhcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests and fixtures 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princhcanal princhcanal princhcanal left review comments

@noice-noise noice-noise noice-noise approved these changes

@beefysalad beefysalad Awaiting requested review from beefysalad beefysalad is a code owner automatically assigned from citu-cpe/pnrn

Assignees

@junix033101 junix033101

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junix033101 @princhcanal @noice-noise