-
Notifications
You must be signed in to change notification settings - Fork 28
t/ckeditor5/1457: Implemented Font Color and Font Background Color features #25
Conversation
…to be more accurate, add feedback for the user when color is selected.
… used color to be applied by splitbutton.
My 2 cents:
|
OK. I think I'm done with reading all that :D |
Corrections
changed to:
It's better not to mention too much details of value that is right below, that way we reduce thw chance that someone edits the listing alone (adds/removes some colors) without updating this particular line. I have simplified manual test description (it was basically duplicating the editable contnet). Issues
minor:
Above things will be extracted to a separate issues not to block this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok all the things extracted, PR is ready to land on master branch. I'll merge it in few mins.
Suggested merge commit message (convention)
Feature: Implemented Font Color and Font Background Color features. Closes ckeditor/ckeditor5#1457.
Additional information
PRs:
ColorGridView
andColorTileView
components ckeditor5-ui#474