This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Added a special character info view #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
suggested changes
Dec 20, 2019
|
|
||
| import '../../theme/characterinfo.css'; | ||
|
|
||
| export default class CharacterInfoView extends View { |
There was a problem hiding this comment.
Please add some docs for the class.
src/ui/characterinfoview.js
Outdated
| this.set( 'character', null ); | ||
| this.set( 'name', null ); | ||
|
|
||
| this.bind( 'code' ).to( this, 'character', char => { |
There was a problem hiding this comment.
Not so needed but maybe extract this to charcterToUnicode function as implementation is not needed here - only what happens in this binding.
src/ui/characterinfoview.js
Outdated
| }, | ||
| children: [ | ||
| { | ||
| text: bind.to( 'name', name => { |
There was a problem hiding this comment.
WDYT about making it compact?
bind.to( 'name', name => name ? name : '\u200B' ) // ZWSP to prevent vertical collapsing.
6 linies for this looks like too much :D
src/ui/charactergridview.js
Outdated
| } | ||
| } ); | ||
|
|
||
| tile.on( 'mouseover', () => { | ||
| this.fire( 'tileHover', { character, name } ); |
There was a problem hiding this comment.
Missing docs for the event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added a special character info view. Closes ckeditor/ckeditor5#5817.
Additional information
Requires CSS: ckeditor/ckeditor5-theme-lark#260