Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Made ComponentFactory.names() return original componenent name. #377

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Made ComponentFactory.names() return original componenent name. #377

merged 1 commit into from
Mar 9, 2018

Conversation

Reinmar
Copy link
Member

@Reinmar Reinmar commented Mar 8, 2018 •
edited by pomek
Loading

Suggested merge commit message (convention)

Other: ComponentFactory.names() will return original component names (instead of normalized names). Closes ckeditor/ckeditor5#5447.

@Reinmar Reinmar requested a review from jodator March 8, 2018 15:59
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d6d5ce on t/376 into cada5d8 on master.

jodator
jodator approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jodator jodator merged commit b6b39d7 into master Mar 9, 2018
@jodator jodator deleted the t/376 branch March 9, 2018 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComponentFactory should not normalise item names on add() but on has() and create()
3 participants
@Reinmar @coveralls @jodator