Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update data source to add routes to default route table of vpc #35

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

h1manshu98
Copy link
Member

What

  • Remove aws_route_table data source and add aws_route_tables data source to include DEFAULT Route-Table as well.

Why

  • If any of the subnet is using DEFAULT route table of the VPC then our current terraform code throws below error for such subnets
╷
│ Error: query returned no results. Please change your search criteria and try again
│
│   with module.vpc_peering.data.aws_route_table.acceptor[20],
│   on .terraform/modules/vpc_peering/main.tf line 120, in data "aws_route_table" "acceptor":
│  120: data "aws_route_table" "acceptor" {
│

@anmolnagpal anmolnagpal merged commit d3b1bdc into master Feb 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants