feat(bgp): add custom BGP import rejection policy support via node annotation #1153
Conversation
lucasmundim
force-pushed
the
custom_import_policy
branch
from
12ded80 to
057a42b
Compare
|
Thanks for submitting this @lucasmundim. We're still focusing on bug fixes for the 1.3 release for a bit, but as we look towards features for 1.4 we'll take a look then. I've added it to the 1.4 project that we use to sort features and requests for the next release. |
Changes the custom import reject annotation support to not only block the given subnet exactly, but also all subnets of the subnet given. For example, this change blocks 10.100.100.0/24 when customimportreject annotation has 10.100.0.0/16 in it.
aauren
force-pushed
the
custom_import_policy
branch
from
057a42b to
c2d6e9a
Compare
|
@lucasmundim Thanks for this work! Apologies that this took so long to get back to! Everything looked pretty much spot on and I think that this fits well with the intention behind the bug fix reported in #586. I've gone ahead and rebased it and pushed it back to your branch. Additionally, in my testing, I found that it wasn't blocking subnets of the ones defined in I don't think that was your intention, so I added another commit that rejects all subnets of subnets that are defined in the annotation. If you can, please take a look and let me know what you think. Assuming you're good with the change, we can merge this. |
|
@aauren Hi, I agree with your suggestion as this should be the expected behavior. Thanks. |
|
Thanks! |
fixes #586 adding another option for protecting required routes.